VR: add rules for traffic between static nat and private gateway static routes by weizhouapache · Pull Request #6153 · apache/cloudstack

weizhouapache · 2022-03-22T12:11:38Z

Description

This PR fixes #6144

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

…ic routes

weizhouapache · 2022-03-22T12:11:48Z

@blueorangutan package

DaanHoogland · 2022-03-22T12:27:31Z

thanks @weizhouapache , looks good. hope that's all there is to it.

DaanHoogland · 2022-03-22T15:12:17Z

@weizhouapache I think this applies to 4.15 and up, can you rebase on an older branch?

weizhouapache · 2022-03-22T18:59:00Z

@blueorangutan package

weizhouapache · 2022-03-23T08:43:56Z

@weizhouapache I think this applies to 4.15 and up, can you rebase on an older branch?

@DaanHoogland
according to https://cwiki.apache.org/confluence/display/CLOUDSTACK/LTS, 4.15.x will be EOL on 1 July 2022
I will change target to 4.16.

weizhouapache · 2022-03-23T08:44:22Z

@blueorangutan package

blueorangutan · 2022-03-23T08:46:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2022-03-23T09:53:01Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 2962

weizhouapache · 2022-03-23T09:54:16Z

@blueorangutan test

blueorangutan · 2022-03-23T09:55:07Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-03-23T18:52:08Z

Trillian test result (tid-3705)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 30847 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6153-t3705-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

nvazquez · 2022-03-25T15:14:35Z

Ping for review @rohityadavcloud @DaanHoogland @Pearl1594

weizhouapache · 2022-04-05T10:05:33Z

@blueorangutan package

blueorangutan · 2022-04-05T10:06:03Z

@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with

SystemVM template(s). I'll keep you posted as I make progress.

blueorangutan · 2022-04-05T11:06:50Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3075

weizhouapache · 2022-04-05T11:28:41Z

@blueorangutan test

blueorangutan · 2022-04-05T11:29:03Z

@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2022-04-05T20:33:24Z

Trillian test result (tid-3821)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31224 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6153-t3821-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

NuxRo

Works for me

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

VR: add rules for traffic between static nat and private gateway stat…

e4bea9d

…ic routes

weizhouapache changed the base branch from main to 4.16 March 23, 2022 08:44

weizhouapache marked this pull request as ready for review March 25, 2022 11:28

weizhouapache added this to the 4.17.0.0 milestone Mar 25, 2022

nvazquez requested review from DaanHoogland, Pearl1594 and yadvr March 25, 2022 15:13

nvazquez added type:bug component:virtual-router labels Mar 25, 2022

nvazquez approved these changes Mar 25, 2022

View reviewed changes

DaanHoogland approved these changes Mar 28, 2022

View reviewed changes

weizhouapache marked this pull request as draft April 5, 2022 11:28

weizhouapache assigned borisstoyanov Apr 5, 2022

nvazquez assigned NuxRo Apr 11, 2022

nvazquez marked this pull request as ready for review April 12, 2022 16:11

NuxRo approved these changes Apr 12, 2022

View reviewed changes

nvazquez merged commit 19a7774 into apache:4.16 Apr 12, 2022

nvazquez mentioned this pull request Apr 12, 2022

Static nat hampers prive gateway access #6144

Closed

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

dc16147

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

957b64b

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

ec2934e

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

625838f

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

0a31855

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

7d02536

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

yadvr pushed a commit to shapeblue/cloudstack that referenced this pull request May 18, 2022

VR: add rules for traffic between static nat and private gateway stat…

a5f251d

…ic routes (apache#6153) (cherry picked from commit 19a7774) Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>

weizhouapache deleted the 4.16-vr-add-rule-static-nat-static-routes branch December 9, 2022 09:14

weizhouapache mentioned this pull request Dec 9, 2024

VR: apply iptables rules when add/remove static routes #10064

Merged

14 tasks

Conversation

weizhouapache commented Mar 22, 2022

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

weizhouapache commented Mar 22, 2022

Uh oh!

DaanHoogland commented Mar 22, 2022

Uh oh!

DaanHoogland commented Mar 22, 2022

Uh oh!

weizhouapache commented Mar 22, 2022

Uh oh!

weizhouapache commented Mar 23, 2022

Uh oh!

weizhouapache commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

weizhouapache commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

blueorangutan commented Mar 23, 2022

Uh oh!

nvazquez commented Mar 25, 2022

Uh oh!

weizhouapache commented Apr 5, 2022

Uh oh!

blueorangutan commented Apr 5, 2022

Uh oh!

blueorangutan commented Apr 5, 2022

Uh oh!

weizhouapache commented Apr 5, 2022

Uh oh!

blueorangutan commented Apr 5, 2022

Uh oh!

blueorangutan commented Apr 5, 2022

Uh oh!

NuxRo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants